feat: new routes for docs, users, search #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2024 17:59
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 65a0b99 in 33 seconds
More details
- Looked at
1677lines of code in33files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/autogen/openapi_model.py:166
- Draft comment:
The introduction of theListResponseclass is a good practice as it standardizes the response format for list endpoints, enhancing API consistency and usability. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a new genericListResponseclass inopenapi_model.pywhich is used across various list endpoints in the routers. This change is consistent and correctly implemented across the TypeScript SDK, Python SDK, and the actual API routes. This is a good practice as it standardizes the response format for all list endpoints, making the API more predictable and easier to work with for developers.
Workflow ID: wflow_7QbdtyBnpEIvPWZp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
added 4 commits
August 5, 2024 17:00
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3b6e81d in 50 seconds
More details
- Looked at
1480lines of code in29files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/ts/src/api/services/DefaultService.ts:321
- Draft comment:
The implementation ofagentsDocsSearchRouteSearchmethod correctly handles different types of search requests and constructs a proper search response. This aligns well with the backend changes and the updated models for search functionality. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces new routes and updates to models and SDKs for handling documents and sessions related to agents. The changes include modifications to the search functionality, particularly around handling different types of search requests (text-only, vector, and hybrid) and the responses they generate. The TypeScript SDK and Python SDK files have been updated to reflect these changes, including new types and schemas for handling search requests and responses. The PR seems to align with the intended functionality as described, focusing on enhancing the search capabilities and ensuring the SDKs are up-to-date with the backend changes.
Workflow ID: wflow_mxJCcSuvdtgTPUY6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
merged commit 2cf9af5
into
dev-tasks-disable-routes
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reimplemented agent and session routes, updated models, and modified SDKs to reflect these changes.
Key points:
agents-api/agents_api/routers/agents.create_agent,create_agent_tool,create_or_update_agent,delete_agent,delete_agent_tool,get_agent_details,list_agent_tools,list_agents,patch_agent,patch_agent_tool,update_agent,update_agent_tool.agents-api/agents_api/routers/sessions.create_or_update_session,create_session,delete_session,get_session,list_sessions,patch_session,update_session.agents-api/agents_api/models.create_agent,utils.agents-api/agents_api/autogen.Chat.py,Entries.py,openapi_model.py.sdks/python/julep/api/types.sdks/ts/src/api/services/DefaultService.ts.typespec/common/interfaces.tsp.Generated with ❤️ by ellipsis.dev